From 1598797767cf97f876bd8df613260375ba8878bb Mon Sep 17 00:00:00 2001 From: Igor Artamonov Date: Tue, 12 Jul 2022 20:56:17 -0400 Subject: [PATCH] problem: unclear how grpc upstream labels works --- .../io/emeraldpay/dshackle/config/UpstreamsConfigReader.kt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/main/kotlin/io/emeraldpay/dshackle/config/UpstreamsConfigReader.kt b/src/main/kotlin/io/emeraldpay/dshackle/config/UpstreamsConfigReader.kt index a118d956..ba06b973 100644 --- a/src/main/kotlin/io/emeraldpay/dshackle/config/UpstreamsConfigReader.kt +++ b/src/main/kotlin/io/emeraldpay/dshackle/config/UpstreamsConfigReader.kt @@ -224,7 +224,11 @@ class UpstreamsConfigReader( upNode: MappingNode, upstream: UpstreamsConfig.Upstream ) { + // Dshackle gRPC connection dispatches requests to different upstreams, which may + // be on different blockchains, and each may have different set of labels. + // So the labels and chains assigned to the gRPC connection make no sense. if (hasAny(upNode, "labels")) { + // Actual labels from underlying upstreams are handled by GrpcUpstreamStatus log.warn("Labels should be not applied to gRPC upstream") } if (hasAny(upNode, "chain")) {