StakeSquid/dshackle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Finalization detector fixes (#554)

Browse Source
This commit is contained in:
KirillPamPam
2024-08-22 14:38:57 +04:00
committed by GitHub
parent a8b91fa84a
commit 32cb726aab
2 changed files with 105 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

91
src/test/kotlin/io/emeraldpay/dshackle/upstream/ethereum/EthereumFinalizationDetectorTest.kt
View File

@@ -3,6 +3,7 @@ package io.emeraldpay.dshackle.upstream.ethereum
import io.emeraldpay.dshackle.Chain
import io.emeraldpay.dshackle.Global
import io.emeraldpay.dshackle.reader.ChainReader
import io.emeraldpay.dshackle.upstream.ChainCallError
import io.emeraldpay.dshackle.upstream.ChainRequest
import io.emeraldpay.dshackle.upstream.ChainResponse
import io.emeraldpay.dshackle.upstream.Upstream
@@ -14,6 +15,8 @@ import io.emeraldpay.dshackle.upstream.rpcclient.ListParams
import org.junit.jupiter.api.Test
import org.mockito.kotlin.doReturn
import org.mockito.kotlin.mock
import org.mockito.kotlin.times
import org.mockito.kotlin.verify
import reactor.core.publisher.Mono
import reactor.test.StepVerifier
import java.time.Duration
@@ -54,6 +57,94 @@ class EthereumFinalizationDetectorTest {
.verify(Duration.ofSeconds(1))
}
@Test
fun `safe and finalized blocks returns null`() {
val reader = mock<ChainReader> {
on {
read(ChainRequest("eth_getBlockByNumber", ListParams("safe", false), 1))
} doReturn Mono.just(ChainResponse(Global.nullValue, null)) doReturn Mono.just(ChainResponse(Global.nullValue, null))
on {
read(ChainRequest("eth_getBlockByNumber", ListParams("finalized", false), 2))
} doReturn Mono.just(ChainResponse(Global.nullValue, null)) doReturn Mono.just(ChainResponse(Global.nullValue, null))
}
val upstream = mock<Upstream> {
on { getIngressReader() } doReturn reader
}
val detector = EthereumFinalizationDetector()
StepVerifier.withVirtualTime { detector.detectFinalization(upstream, Duration.ofSeconds(10), Chain.ZKSYNC__MAINNET) }
.expectSubscription()
.thenAwait(Duration.ofSeconds(0))
.expectNoEvent(Duration.ofMillis(50))
.thenAwait(Duration.ofSeconds(15))
.expectNoEvent(Duration.ofMillis(50))
.thenCancel()
.verify(Duration.ofSeconds(1))
verify(reader, times(2)).read(ChainRequest("eth_getBlockByNumber", ListParams("safe", false), 1))
verify(reader, times(2)).read(ChainRequest("eth_getBlockByNumber", ListParams("finalized", false), 2))
}
@Test
fun `disable detector if receive specific errors`() {
val reader = mock<ChainReader> {
on {
read(ChainRequest("eth_getBlockByNumber", ListParams("safe", false), 1))
} doReturn Mono.just(ChainResponse(null, ChainCallError(1, "Got an invalid block number, check it")))
on {
read(ChainRequest("eth_getBlockByNumber", ListParams("finalized", false), 2))
} doReturn response(2) doReturn response(10)
}
val upstream = mock<Upstream> {
on { getIngressReader() } doReturn reader
}
val detector = EthereumFinalizationDetector()
StepVerifier.withVirtualTime { detector.detectFinalization(upstream, Duration.ofSeconds(10), Chain.ZKSYNC__MAINNET) }
.expectSubscription()
.thenAwait(Duration.ofSeconds(0))
.expectNext(FinalizationData(2L, FinalizationType.FINALIZED_BLOCK))
.thenAwait(Duration.ofSeconds(15))
.expectNext(FinalizationData(10L, FinalizationType.FINALIZED_BLOCK))
.thenCancel()
.verify(Duration.ofSeconds(1))
verify(reader).read(ChainRequest("eth_getBlockByNumber", ListParams("safe", false), 1))
verify(reader, times(2)).read(ChainRequest("eth_getBlockByNumber", ListParams("finalized", false), 2))
}
@Test
fun `ignore response if it cannot be parsed`() {
val reader = mock<ChainReader> {
on {
read(ChainRequest("eth_getBlockByNumber", ListParams("safe", false), 1))
} doReturn Mono.just(ChainResponse("""{"name": "value"}""".toByteArray(), null)) doReturn Mono.just(ChainResponse("""{"name": "value"}""".toByteArray(), null))
on {
read(ChainRequest("eth_getBlockByNumber", ListParams("finalized", false), 2))
} doReturn response(2) doReturn response(10)
}
val upstream = mock<Upstream> {
on { getIngressReader() } doReturn reader
}
val detector = EthereumFinalizationDetector()
StepVerifier.withVirtualTime { detector.detectFinalization(upstream, Duration.ofSeconds(10), Chain.ZKSYNC__MAINNET) }
.expectSubscription()
.thenAwait(Duration.ofSeconds(0))
.expectNext(FinalizationData(2L, FinalizationType.FINALIZED_BLOCK))
.thenAwait(Duration.ofSeconds(15))
.expectNext(FinalizationData(10L, FinalizationType.FINALIZED_BLOCK))
.thenCancel()
.verify(Duration.ofSeconds(1))
verify(reader, times(2)).read(ChainRequest("eth_getBlockByNumber", ListParams("safe", false), 1))
verify(reader, times(2)).read(ChainRequest("eth_getBlockByNumber", ListParams("finalized", false), 2))
}
private fun response(blockNumber: Long) =
Mono.just(
ChainResponse(