StakeSquid/dshackle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix streaming spam (#486)

Browse Source
This commit is contained in:
KirillPamPam
2024-05-28 13:51:25 +04:00
committed by GitHub
parent 4ea965528f
commit 387cd31c98
3 changed files with 95 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

105
src/main/kotlin/io/emeraldpay/dshackle/upstream/rpcclient/stream/JsonRpcStreamParser.kt
View File

@@ -37,10 +37,7 @@ class JsonRpcStreamParser(
private const val QUOTE: Byte = '"'.code.toByte()
}
fun streamParse(
statusCode: Int,
response: Flux<ByteArray>,
): Mono<out Response> {
fun streamParse(statusCode: Int, response: Flux<ByteArray>): Mono<out Response> {
val firstPartSize = AtomicInteger()
return response.bufferUntil {
if (firstPartSize.get() > firstChunkMaxSize) {
@@ -110,10 +107,7 @@ class JsonRpcStreamParser(
}
}
private fun aggregateResponse(
response: Flux<ByteArray>,
statusCode: Int,
): Mono<AggregateResponse> {
private fun aggregateResponse(response: Flux<ByteArray>, statusCode: Int): Mono<AggregateResponse> {
return ByteBufFlux.fromInbound(response).aggregate().asByteArray()
.map { AggregateResponse(it, statusCode) }
}
@@ -170,7 +164,8 @@ class JsonRpcStreamParser(
var response: SingleResponse? = null
try {
jsonFactory.createParser(firstBytes).use { parser ->
while (parser.nextToken() != null) {
while (true) {
parser.nextToken()
if (firstBytes.size == parser.currentLocation.byteOffset.toInt()) {
break
}
@@ -178,56 +173,51 @@ class JsonRpcStreamParser(
if (parser.currentName == "result") {
val token = parser.nextToken()
val tokenStart = parser.tokenLocation.byteOffset.toInt()
if (token.isScalarValue) {
response = if (token.isScalarValue) {
val count = CountQuotesAndSlashes(AtomicInteger(1))
whatCount.set(count)
response =
SingleResponse(
processScalarValue(parser, tokenStart, firstBytes, count, endStream),
null,
).merge(response)
SingleResponse(
processScalarValue(parser, tokenStart, firstBytes, count, endStream),
null,
)
} else {
when (token) {
JsonToken.START_OBJECT -> {
val count =
CountObjectBrackets(
AtomicInteger(1),
CountQuotesAndSlashes(AtomicInteger(0)),
)
val count = CountObjectBrackets(
AtomicInteger(1),
CountQuotesAndSlashes(AtomicInteger(0)),
)
whatCount.set(count)
response =
SingleResponse(
processAndCountBrackets(
tokenStart,
firstBytes,
count,
endStream,
OBJECT_OPEN_BRACKET,
OBJECT_CLOSE_BRACKET,
),
null,
).merge(response)
SingleResponse(
processAndCountBrackets(
tokenStart,
firstBytes,
count,
endStream,
OBJECT_OPEN_BRACKET,
OBJECT_CLOSE_BRACKET,
),
null,
)
}
JsonToken.START_ARRAY -> {
val count =
CountArrayBrackets(
AtomicInteger(1),
CountQuotesAndSlashes(AtomicInteger(0)),
)
val count = CountArrayBrackets(
AtomicInteger(1),
CountQuotesAndSlashes(AtomicInteger(0)),
)
whatCount.set(count)
response =
SingleResponse(
processAndCountBrackets(
tokenStart,
firstBytes,
count,
endStream,
ARRAY_OPEN_BRACKET,
ARRAY_CLOSE_BRACKET,
),
null,
).merge(response)
SingleResponse(
processAndCountBrackets(
tokenStart,
firstBytes,
count,
endStream,
ARRAY_OPEN_BRACKET,
ARRAY_CLOSE_BRACKET,
),
null,
)
}
else -> {
@@ -235,15 +225,28 @@ class JsonRpcStreamParser(
}
}
}
if (endStream.get()) {
// we parsed the whole result field, and we can go parse further
parser.skipChildren()
} else {
// otherwise return response assuming there is no error field
return response
}
} else if (parser.currentName == "error") {
return SingleResponse(null, responseRpcParser.readError(parser)).merge(response)
return SingleResponse(response?.result, responseRpcParser.readError(parser))
}
}
}
return response
}
} catch (e: Exception) {
log.warn("Streaming parsing exception: {}", e.message)
if (response == null) {
// something terrible happened when we even don't have a response that means we haven't parsed the first chunk
log.warn("Streaming parsing exception: {}", e.message)
}
// there may be other parsing exceptions that means we have parsed the first chunk, and we have a response
// but when we want to parse further we can get an error if the first chunk is not a finished json
// it doesn't matter, we have the result from the response and can return it
return response
}
}

15
src/main/kotlin/io/emeraldpay/dshackle/upstream/stream/Responses.kt
View File

@@ -13,21 +13,6 @@ data class SingleResponse(
fun noResponse() = result == null && error == null
fun merge(other: SingleResponse?): SingleResponse {
if (other == null) {
return this
}
var newResult: ByteArray? = result
var newError: ChainCallError? = error
if (newResult == null && other.result != null) {
newResult = other.result
}
if (newError == null && other.error != null) {
newError = other.error
}
return SingleResponse(newResult, newError)
}
override fun equals(other: Any?): Boolean {
if (this === other) return true
if (other !is SingleResponse) return false