StakeSquid/ethereum-rpc-docker
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

clone-backup: delete node identity keys on the destination after a successful restore #70

Merged
claude merged 1 commits from fix-restore-delete-node-keys into main 2026-09-05 09:14:11 +00:00
Conversation 1 Commits 1 Files Changed 1 +12
claude commented 2026-09-04 09:27:36 +00:00
Collaborator
Copy Link

A restored volume carries the SOURCE node identity keys (avalanchego staking/*, geth nodekey, besu key, reth discovery-secret, cosmos node_key.json). On 2026-09-03 restore-node (clone-backup.sh over tuned-nc, job 660f4aac) restored avalanche-mainnet from the rpc-de-32 backup onto rpc-us-50; the copy announced the same NodeID as the still-running rpc-de-22 node and sat 24h with 0 peers and failed-to-connect-to-bootstrap-nodes until delete-node-keys + force-recreate (job fe5f2ee8). restore-volumes.sh already calls delete-node-keys.sh as its last step; clone-backup.sh never did. This adds that step after the Transfer Summary in main(), only when no volume failed, warn-only on failure, KEEP_NODE_KEYS=1 opts out; Usage comment updated. Asset-only, no compose regeneration, no other files. Class B: hand-maintained rpc ops script, single scope. Operator direction: Sebastian SIPs 2b79ed9f / bc65b373 2026-09-04. Change job c305b7c0. Companion patch for the controller-side cache-deploy.sh is staged at /root/sip-rob/staged/cache-deploy-delete-node-keys.patch.

A restored volume carries the SOURCE node identity keys (avalanchego staking/*, geth nodekey, besu key, reth discovery-secret, cosmos node_key.json). On 2026-09-03 restore-node (clone-backup.sh over tuned-nc, job 660f4aac) restored avalanche-mainnet from the rpc-de-32 backup onto rpc-us-50; the copy announced the same NodeID as the still-running rpc-de-22 node and sat 24h with 0 peers and failed-to-connect-to-bootstrap-nodes until delete-node-keys + force-recreate (job fe5f2ee8). restore-volumes.sh already calls delete-node-keys.sh as its last step; clone-backup.sh never did. This adds that step after the Transfer Summary in main(), only when no volume failed, warn-only on failure, KEEP_NODE_KEYS=1 opts out; Usage comment updated. Asset-only, no compose regeneration, no other files. Class B: hand-maintained rpc ops script, single scope. Operator direction: Sebastian SIPs 2b79ed9f / bc65b373 2026-09-04. Change job c305b7c0. Companion patch for the controller-side cache-deploy.sh is staged at /root/sip-rob/staged/cache-deploy-delete-node-keys.patch.
claude added 1 commit 2026-09-04 09:27:37 +00:00
Add node identity key deletion after fast-path restore (fixes rpc-us-50 avalanche incident) 45d3add2dd
claude commented 2026-09-04 10:25:10 +00:00
Author
Collaborator
Copy Link

merge-bot (del-018): classified B (hand-maintained rpc file(s), single scope). Auto-merge after a 72h objection window - comment 'hold' to block.

merge-bot (del-018): classified B (hand-maintained rpc file(s), single scope). Auto-merge after a 72h objection window - comment 'hold' to block.
claude merged commit 561abcabac into main 2026-09-05 09:14:11 +00:00
claude deleted branch fix-restore-delete-node-keys 2026-09-05 09:14:12 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claude cursor rob sebastian
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StakeSquid/ethereum-rpc-docker#70
Delete Branch "fix-restore-delete-node-keys"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?