StakeSquid/dshackle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

problem: NativeCall replies are logged only on complete

Browse Source 
solution: add to the log at the moment of reply
This commit is contained in:
Igor Artamonov
2021-07-05 21:51:15 -04:00
parent 6cb703ec4e
commit 0d144a44a9
3 changed files with 54 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/main/kotlin/io/emeraldpay/dshackle/monitoring/accesslog/AccessHandler.kt
View File

@@ -110,13 +110,14 @@ class AccessHandler(
.start(headers, call.attributes)
val callWrapper: ServerCall<ReqT, RespT> = OnNativeCallResponse(
call as ServerCall<BlockchainOuterClass.NativeCallRequest, BlockchainOuterClass.NativeCallReplyItem>, builder
call as ServerCall<BlockchainOuterClass.NativeCallRequest, BlockchainOuterClass.NativeCallReplyItem>,
builder,
accessLogWriter
) as ServerCall<ReqT, RespT>
return OnNativeCall(
next.startCall(callWrapper, headers) as ServerCall.Listener<BlockchainOuterClass.NativeCallRequest>,
builder) { logs ->
accessLogWriter.submit(logs)
} as ServerCall.Listener<ReqT>
builder
) as ServerCall.Listener<ReqT>
}
@Suppress("UNCHECKED_CAST")
@@ -205,29 +206,18 @@ class AccessHandler(
class OnNativeCall(
val next: ServerCall.Listener<BlockchainOuterClass.NativeCallRequest>,
val builder: EventsBuilder.NativeCall,
val done: (List<Events.NativeCall>) -> Unit
val builder: EventsBuilder.NativeCall
) : ForwardingServerCallListener<BlockchainOuterClass.NativeCallRequest>() {
override fun onMessage(message: BlockchainOuterClass.NativeCallRequest) {
val chain = message.chain
builder.withChain(chain.number)
message.itemsList.forEach { item ->
builder.onItem(item)
builder.onRequest(item)
}
super.onMessage(message)
}
override fun onCancel() {
super.onCancel()
done(builder.build())
}
override fun onComplete() {
super.onComplete()
done(builder.build())
}
override fun delegate(): ServerCall.Listener<BlockchainOuterClass.NativeCallRequest> {
return next
}
@@ -279,11 +269,14 @@ class AccessHandler(
class OnNativeCallResponse(
next: ServerCall<BlockchainOuterClass.NativeCallRequest, BlockchainOuterClass.NativeCallReplyItem>,
val builder: EventsBuilder.NativeCall
val builder: EventsBuilder.NativeCall,
val accessLogWriter: AccessLogWriter
) : BaseCallResponse<BlockchainOuterClass.NativeCallRequest, BlockchainOuterClass.NativeCallReplyItem>(next) {
override fun sendMessage(message: BlockchainOuterClass.NativeCallReplyItem) {
builder.onItemReply(message)
accessLogWriter.submit(
builder.onReply(message)
)
super.sendMessage(message)
}
}

35
src/main/kotlin/io/emeraldpay/dshackle/monitoring/accesslog/EventsBuilder.kt
View File

@@ -186,12 +186,13 @@ class EventsBuilder {
class NativeCall : Base<NativeCall>() {
val items = ArrayList<Events.NativeCallItemDetails>()
val replies = HashMap<Int, Events.NativeCallReplyDetails>()
private var index = 0
override fun getT(): NativeCall {
return this
}
fun onItem(item: BlockchainOuterClass.NativeCallItem): NativeCall {
fun onRequest(item: BlockchainOuterClass.NativeCallItem): NativeCall {
this.items.add(
Events.NativeCallItemDetails(
item.method,
@@ -202,30 +203,20 @@ class EventsBuilder {
return this
}
fun onItemReply(reply: BlockchainOuterClass.NativeCallReplyItem): NativeCall {
this.replies[reply.id] = Events.NativeCallReplyDetails(
reply.id,
reply.succeed,
reply.payload?.size()?.toLong() ?: 0L
fun onReply(reply: BlockchainOuterClass.NativeCallReplyItem): Events.NativeCall {
val item = items.find { it.id == reply.id }!!
return Events.NativeCall(
request = requestDetails,
total = items.size,
index = index++,
succeed = reply.succeed,
blockchain = chain,
nativeCall = item,
payloadSizeBytes = item.payloadSizeBytes,
id = UUID.randomUUID()
)
return this
}
fun build(): List<Events.NativeCall> {
return items.mapIndexed { index, item ->
val reply = replies[item.id]
Events.NativeCall(
request = requestDetails,
total = items.size,
index = index,
succeed = reply?.succeed ?: false,
blockchain = chain,
nativeCall = item,
payloadSizeBytes = item.payloadSizeBytes,
id = UUID.randomUUID()
)
}
}
}
class Describe : Base<Describe>() {

68
src/test/groovy/io/emeraldpay/dshackle/monitoring/accesslog/EventsBaseBuilderSpec.groovy
View File

@@ -35,18 +35,15 @@ class EventsBaseBuilderSpec extends Specification {
def act = new EventsBuilder.NativeCall()
.start(metadata, attributes)
.withChain(Chain.ETHEREUM.id)
.onItem(BlockchainOuterClass.NativeCallItem.getDefaultInstance())
.build()
.onRequest(BlockchainOuterClass.NativeCallItem.getDefaultInstance())
.onReply(BlockchainOuterClass.NativeCallReplyItem.getDefaultInstance())
then:
act.size() == 1
with(act[0]) {
it.request != null
it.request.remote != null
with(it.request.remote) {
ips == ["127.0.0.1"]
userAgent == "grpc-go/1.30.0"
ip == "127.0.0.1"
}
act.request != null
act.request.remote != null
with(act.request.remote) {
ips == ["127.0.0.1"]
userAgent == "grpc-go/1.30.0"
ip == "127.0.0.1"
}
}
@@ -62,11 +59,10 @@ class EventsBaseBuilderSpec extends Specification {
def act = new EventsBuilder.NativeCall()
.start(metadata, attributes)
.withChain(Chain.ETHEREUM.id)
.onItem(BlockchainOuterClass.NativeCallItem.getDefaultInstance())
.build()
.onRequest(BlockchainOuterClass.NativeCallItem.getDefaultInstance())
.onReply(BlockchainOuterClass.NativeCallReplyItem.getDefaultInstance())
then:
act.size() == 1
with(act[0].request.remote) {
with(act.request.remote) {
ips == ["30.56.100.15", "127.0.0.1"]
ip == "30.56.100.15"
}
@@ -84,11 +80,10 @@ class EventsBaseBuilderSpec extends Specification {
def act = new EventsBuilder.NativeCall()
.start(metadata, attributes)
.withChain(Chain.ETHEREUM.id)
.onItem(BlockchainOuterClass.NativeCallItem.getDefaultInstance())
.build()
.onRequest(BlockchainOuterClass.NativeCallItem.getDefaultInstance())
.onReply(BlockchainOuterClass.NativeCallReplyItem.getDefaultInstance())
then:
act.size() == 1
with(act[0].request.remote) {
with(act.request.remote) {
ips == ["192.168.1.1", "30.56.100.15"]
userAgent == "grpc-go/1.30.0"
ip == "30.56.100.15"
@@ -107,11 +102,10 @@ class EventsBaseBuilderSpec extends Specification {
def act = new EventsBuilder.NativeCall()
.start(metadata, attributes)
.withChain(Chain.ETHEREUM.id)
.onItem(BlockchainOuterClass.NativeCallItem.getDefaultInstance())
.build()
.onRequest(BlockchainOuterClass.NativeCallItem.getDefaultInstance())
.onReply(BlockchainOuterClass.NativeCallReplyItem.getDefaultInstance())
then:
act.size() == 1
with(act[0].request.remote) {
with(act.request.remote) {
ips == ["30.56.100.15"]
userAgent == "grpc-go/1.30.0"
ip == "30.56.100.15"
@@ -130,11 +124,10 @@ class EventsBaseBuilderSpec extends Specification {
def act = new EventsBuilder.NativeCall()
.start(metadata, attributes)
.withChain(Chain.ETHEREUM.id)
.onItem(BlockchainOuterClass.NativeCallItem.getDefaultInstance())
.build()
.onRequest(BlockchainOuterClass.NativeCallItem.getDefaultInstance())
.onReply(BlockchainOuterClass.NativeCallReplyItem.getDefaultInstance())
then:
act.size() == 1
with(act[0].request.remote) {
with(act.request.remote) {
ips == ["30.56.100.15"]
userAgent == "grpc-go/1.30.0"
ip == "30.56.100.15"
@@ -153,11 +146,10 @@ class EventsBaseBuilderSpec extends Specification {
def act = new EventsBuilder.NativeCall()
.start(metadata, attributes)
.withChain(Chain.ETHEREUM.id)
.onItem(BlockchainOuterClass.NativeCallItem.getDefaultInstance())
.build()
.onRequest(BlockchainOuterClass.NativeCallItem.getDefaultInstance())
.onReply(BlockchainOuterClass.NativeCallReplyItem.getDefaultInstance())
then:
act.size() == 1
with(act[0].request.remote) {
with(act.request.remote) {
ips == ["2001:db8:0:0:0:ff00:42:8329", "0:0:0:0:0:0:0:1"]
ip == "2001:db8:0:0:0:ff00:42:8329"
}
@@ -174,11 +166,10 @@ class EventsBaseBuilderSpec extends Specification {
def act = new EventsBuilder.NativeCall()
.start(metadata, attributes)
.withChain(Chain.ETHEREUM.id)
.onItem(BlockchainOuterClass.NativeCallItem.getDefaultInstance())
.build()
.onRequest(BlockchainOuterClass.NativeCallItem.getDefaultInstance())
.onReply(BlockchainOuterClass.NativeCallReplyItem.getDefaultInstance())
then:
act.size() == 1
with(act[0].request.remote) {
with(act.request.remote) {
userAgent == "grpc-go/1.30.0 xss"
}
}
@@ -195,11 +186,10 @@ class EventsBaseBuilderSpec extends Specification {
def act = new EventsBuilder.NativeCall()
.start(metadata, attributes)
.withChain(Chain.ETHEREUM.id)
.onItem(BlockchainOuterClass.NativeCallItem.getDefaultInstance())
.build()
.onRequest(BlockchainOuterClass.NativeCallItem.getDefaultInstance())
.onReply(BlockchainOuterClass.NativeCallReplyItem.getDefaultInstance())
then:
act.size() == 1
with(act[0].request.remote) {
with(act.request.remote) {
userAgent.length() == 128
userAgent == "0123456_1_0123456_2_0123456_3_0123456_4_0123456_5_0123456_6_0123456_7_0123456_8_0123456_9_0123456_0_0123456_1_0123456_2_0123456_"
}