Merge pull request #10 from p2p-org/fix_divide_by_zero_error

log failed validation
2022-09-05 17:51:26 +03:00
parent 843d3c141e b6cdfb89c6
commit efe9ee9730
1 changed files with 6 additions and 1 deletions
--- a/src/main/kotlin/io/emeraldpay/dshackle/upstream/AbstractHead.kt
+++ b/src/main/kotlin/io/emeraldpay/dshackle/upstream/AbstractHead.kt
@@ -57,7 +57,12 @@ abstract class AbstractHead(
            }
            .subscribeOn(Schedulers.boundedElastic())
            .subscribe { block ->
-                if (blockValidator.isValid(forkChoice.getHead(), block)) {
+                val valid = runCatching {
+                    blockValidator.isValid(forkChoice.getHead(), block)
+                }.onFailure {
+                    log.error("Block ${block.hash} validation failed with '${it.message}'", it)
+                }.getOrElse { false }
+                if (valid) {
                    notifyBeforeBlock()
                    when (val choiceResult = forkChoice.choose(block)) {
                        is ForkChoice.ChoiceResult.Updated -> {